Chore: [AEA-0000] - workflow to update dev container#640
Conversation
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
Adds a scheduled/manual GitHub Actions workflow that invokes a reusable workflow from NHSDigital/eps-common-workflows to automatically update the repository devcontainer version.
Changes:
- Introduces
.github/workflows/update_dev_container_version.ymlwithworkflow_dispatch+ weeklyscheduletriggers. - Calls the shared
update-dev-container-version.ymlreusable workflow pinned to a specific commit SHA and passes the base branch + GitHub App secrets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| workflow_dispatch: | ||
| schedule: | ||
| - cron: "0 18 * * 4" | ||
|
|
||
| jobs: | ||
| update_devcontainer_version: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6 | ||
| permissions: | ||
| contents: read | ||
| packages: read | ||
| pull-requests: write | ||
| with: | ||
| base_branch: main | ||
| secrets: | ||
| CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }} | ||
| CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }} |
There was a problem hiding this comment.
Indentation in this workflow uses 4+ spaces under on:/jobs: (e.g., workflow_dispatch, schedule, and the job definition). The rest of the workflows in this repo consistently use 2-space indentation, so aligning this file to that convention would improve readability and reduce diff noise in future edits.
| workflow_dispatch: | |
| schedule: | |
| - cron: "0 18 * * 4" | |
| jobs: | |
| update_devcontainer_version: | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6 | |
| permissions: | |
| contents: read | |
| packages: read | |
| pull-requests: write | |
| with: | |
| base_branch: main | |
| secrets: | |
| CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }} | |
| CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }} | |
| workflow_dispatch: | |
| schedule: | |
| - cron: "0 18 * * 4" | |
| jobs: | |
| update_devcontainer_version: | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6 | |
| permissions: | |
| contents: read | |
| packages: read | |
| pull-requests: write | |
| with: | |
| base_branch: main | |
| secrets: | |
| CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }} | |
| CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }} |
| workflow_dispatch: | ||
| schedule: | ||
| - cron: "0 18 * * 4" | ||
|
|
There was a problem hiding this comment.
Because this workflow can be triggered both on a schedule and manually (workflow_dispatch), two runs can overlap and potentially open duplicate/competing PRs. Consider adding a concurrency group (and optionally cancel-in-progress: true) to ensure only one update run executes at a time.
| concurrency: | |
| group: update-devcontainer-version | |
| cancel-in-progress: true |
|
Summary
Details